Return false instead of crashing when asking if a repeat can be added at a deleted position #734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #getodk/collect#5539
What has been done to verify that this works as intended?
I've added tests and also tested the fix with ODK Collect.
Why is this the best possible solution? Were any other approaches considered?
In ODK Collect when we remove a repeat we need to find the last relevant index. In this case we navigate back and check every possible index. If something does not exist we don't want any exceptions but just simple false value.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It's a safe fix so testing the described scenario should be enough.
Do we need any specific form for testing your changes? If so, please attach one.
any form with nested repeats and
repeat_count
like the one attached in getodk/collect#5539Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.