-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
pelican-quickstart: switch to jinja2 #2122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do we really need to make flake8-import-order happy?
|
Closing due to inactivity |
Apologies, @ix5. It's been a busy year. Any @getpelican/reviewers have a moment to review this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the review delay, @ix5. I ran pelican-quickstart
, and the generated Makefile
and configuration files all look good! There are few changes that need to be pulled in (see merge conflicts), but other than that, this seems good to merge to me. 👍
- Use the jinja2 templating language for Makefile, fabfile, pelicanconf, publishconf, and develop-server.sh - Add logic in pelican_quickstart.py - Let jinja2 handle opening and reading template files - Remove thus unused functions for string.Template
Heh, I saw the growing backlog of issues and PRs, didn't want to keep it that way and closed this one. Anyway, I've rebased off master, fixed conflicts, should be good to go. Travis gives the go-ahead as well. Thanks for keeping this project running, @justinmayer, you're a treasure. And thank you @iKevinY as well! |
Hey @iKevinY @justinmayer could you please merge this? |
As per request by @justinmayer on issue #2000, to omit unused build targets and allow for more powerful templating.
pelicanconf, publishconf, and develop-server.sh