-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feed link inside feed should use FEED_DOMAIN #290
Conversation
The initial work on enabling feeds to be served from a different domain than the site domain focused on the feed link displayed inside the base template. But there is also a feed link inside the generated feed itself, which this commit updates to use the FEED_DOMAIN value (if defined). Also, it turns out that the FEED_MAIN_URL setting is not necessary; the existing FEED and FEED_RSS functionality is simpler and can address the targeted use case just as easily. That attribute has been removed from the settings and template, along with corresponding changes to the docs. Refs getpelican#177.
The ID of a feed entry should never change, but the previous method of generating the ID -- i.e., using the entry URL -- results in an ID that is not permanent and can change. Switching to the tag URI method from RFC 4151 should help improve the long-term uniqueness and permanence of entry IDs, as espoused here: <http://web.archive.org/web/20110514113830/http://diveintomark.org/archives/2004/05/28/howto-atom-id> Also added a trailing slash to the site URL inside the feed; the lack thereof was causing a feed validation warning.
Feed link inside feed should use FEED_DOMAIN
I'm not sure but if I understand well this new behaviour, I must change my feedburner address from |
I certainly understand your consternation. I will do my best to explain how to configure things such that there should be no disruption for you. First, it's important to understand that there was a problem with the previous behavior: the value defined in the In your case, I suggest setting your Of course, in this case the feed file will be written to the web root instead of Hopefully this has been helpful and has not simply resulted in muddying the waters further. Please let me know if I can be of any further assistance. :^) |
thanks for the detailed answer, I understand the issue and will try your solution. |
The initial work on enabling feeds to be served from a different domain
than the site domain focused on the feed link displayed inside the
base template. But there is also a feed link inside the generated feed
itself, which this commit updates to use the FEED_DOMAIN value (if
defined).
Also, it turns out that the FEED_MAIN_URL setting is not necessary; the
existing FEED and FEED_RSS functionality is simpler and can address the
targeted use case just as easily. That attribute has been removed from
the settings and template, along with corresponding changes to the docs.
Refs #177.