Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add --dry-run option to 'popper run' #509

Closed
ivotron opened this issue Mar 4, 2019 · 2 comments
Closed

cli: add --dry-run option to 'popper run' #509

ivotron opened this issue Mar 4, 2019 · 2 comments

Comments

@ivotron
Copy link
Collaborator

ivotron commented Mar 4, 2019

Add a --dry-run option that just prints what the workflow would look like without actually executing it

@akashrajr1
Copy link
Contributor

@ivotron can you explain this issue? Do we have to print the order of the actions being executed in a workflow?
For this workflow do we print the order of execution of actions like this - test init, test ci, test reuse, end.

@ivotron
Copy link
Collaborator Author

ivotron commented Mar 7, 2019

@akashrajr1 For example, for this workflow, the output looks like this:

[install] docker pull node:11.6.0
[install] docker create node:11.6.0 npm install
[install] docker start ...
[lint] docker build -t action/jshint /tmp/gha-demo/./.github/actions/jshint
[lint] docker create action/jshint 
[lint] docker start .
[test] docker pull node:11.6.0
[test] docker create node:11.6.0 npm test
[test] docker start .
[branch-filter] docker build -t actions/bin /tmp/actions/actions/bin/./filter
[branch-filter] docker create actions/bin branch master
[branch-filter] docker start .
[deploy] docker build -t actions/bin /tmp/actions/actions/bin/./sh
[deploy] docker create actions/bin env
[deploy] docker start .

For this issue, we can print a DRYRUN: prefix for every line, something like this:

DRYRUN: [install] docker pull node:11.6.0
DRYRUN: [install] docker create node:11.6.0 npm install
DRYRUN: [install] docker start ...
DRYRUN: [lint] docker build -t action/jshint /tmp/gha-demo/./.github/actions/jshint
DRYRUN: [lint] docker create action/jshint 
DRYRUN: [lint] docker start .
DRYRUN: [test] docker pull node:11.6.0
DRYRUN: [test] docker create node:11.6.0 npm test
DRYRUN: [test] docker start .
DRYRUN: [branch-filter] docker build -t actions/bin /tmp/actions/actions/bin/./filter
DRYRUN: [branch-filter] docker create actions/bin branch master
DRYRUN: [branch-filter] docker start .
DRYRUN: [deploy] docker build -t actions/bin /tmp/actions/actions/bin/./sh
DRYRUN: [deploy] docker create actions/bin env
DRYRUN: [deploy] docker start .

this would let the user know that nothing got executed, just printed.

akashrajr1 added a commit to akashrajr1/popper that referenced this issue Mar 11, 2019
Does a dry run of a workflow
Resolves issue getpopper#509
akashrajr1 added a commit to akashrajr1/popper that referenced this issue Mar 12, 2019
Does a dry run of a workflow
Resolves issue getpopper#509
akashrajr1 added a commit to akashrajr1/popper that referenced this issue Mar 12, 2019
Does a dry run of a workflow
Resolves issue getpopper#509
akashrajr1 added a commit to akashrajr1/popper that referenced this issue Mar 13, 2019
Does a dry run of a workflow
Resolves issue getpopper#509
akashrajr1 added a commit to akashrajr1/popper that referenced this issue Mar 18, 2019
Does a dry run of a workflow
Resolves issue getpopper#509

fix pep8

--dry-run review changes

Dry run is no longer in a seperate module, and has been integrated in the gha module

Fix a build issue

Bad import statement

fix pep8
ivotron pushed a commit that referenced this issue May 24, 2020
Adds a --dry-run flag to the 'popper run' command

fixes #509
ivotron pushed a commit that referenced this issue May 25, 2020
Adds a --dry-run flag to the 'popper run' command

fixes #509
ivotron pushed a commit that referenced this issue May 25, 2020
Adds a --dry-run flag to the 'popper run' command

fixes #509
ivotron pushed a commit that referenced this issue May 25, 2020
Adds a --dry-run flag to the 'popper run' command

fixes #509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants