Fix setting PORTER_HOME on plugins #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running a plugin, I was setting PORTER_HOME improperly. Windows was having none of it and was refusing to run the plugin with an improperly formatted env var, returning The parameter is incorrect
|
/azp run porter-install-check |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Do a quick check that porter list works on all OSes during our install check as a smoke test that what we installed works. This is a stopgap until we can run our full test suite on all OSes in our PR CI run.
|
/azp run porter-install-check |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I triggered the porter-install-check build that normally only runs on main so that you can see how it will catch problems like this bug next time when there is a regression. It is failing because it is testing canary and not this PRs build (that's the nature of that test). I expect it to pass when this PR is merged based on my manual testing on my local windows machine. It will need to be a separate effort to get our build running on a matrix of OSes for PR builds.
|
vdice
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
When running a plugin, I was setting PORTER_HOME improperly. Windows was having none of it and was refusing to run the plugin with an improperly formatted env var, returning
What issue does it fix
Closes #1154
Notes for the reviewer
As a follow-up I'm looking at https://docs.microsoft.com/en-us/azure/devops/pipelines/get-started-multiplatform?view=azure-devops to change our build to run on more than one OS. At first we can just run the CLI tests until we can build on all operating systems (not sure if building on windows is at 100% yet).
In the meantime, I've added a
porter listcall to our install script e2e test which does run on all OSs. This seems like a good thing to do anyway, make sure that Porter is not only installed but can run our most basic command without error.Checklist