Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting PORTER_HOME on plugins #1235

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Fix setting PORTER_HOME on plugins #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50d8711
Fix setting PORTER_HOME on plugins
carolynvs Aug 27, 2020
26e2bf3
Test porter list in our xplat install check
carolynvs Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/plugins/pluggable/loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func (l *PluginLoader) Load(pluginType PluginTypeConfig) (interface{}, func(), e
if err != nil {
return nil, nil, err
}
pluginCommand.Env = append(pluginCommand.Env, home)
pluginCommand.Env = append(pluginCommand.Env, fmt.Sprintf("PORTER_HOME=%s", home))
}

if l.DebugPlugins {
Expand Down
1 change: 1 addition & 0 deletions scripts/test/test-linux-install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ set -xeuo pipefail
export PATH=$PATH:~/.porter

PORTER_PERMALINK=canary ./scripts/install/install-linux.sh
porter list

PORTER_PERMALINK=v0.23.0-beta.1 ./scripts/install/install-linux.sh
porter version | grep v0.23.0-beta.1
Expand Down
1 change: 1 addition & 0 deletions scripts/test/test-mac-install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ set -xeuo pipefail
export PATH=$PATH:~/.porter

PORTER_PERMALINK=canary ./scripts/install/install-mac.sh
porter list

PORTER_PERMALINK=v0.23.0-beta.1 ./scripts/install/install-mac.sh
porter version | grep v0.23.0-beta.1
Expand Down
1 change: 1 addition & 0 deletions scripts/test/test-windows-install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ $ErrorActionPreference = "Stop"
$env:PATH+=";$env:USERPROFILE\.porter"

& $PSScriptRoot\..\install\install-windows.ps1 -PORTER_PERMALINK canary
porter list

& $PSScriptRoot\..\install\install-windows.ps1 -PORTER_PERMALINK v0.23.0-beta.1
if (-Not (porter version | Select-String -Pattern 'v0.23.0-beta.1' -SimpleMatch))
Expand Down