Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split integration tests into separate build #1564

Merged
merged 18 commits into from
May 10, 2021
Merged

Split integration tests into separate build #1564

merged 18 commits into from
May 10, 2021

Conversation

carolynvs
Copy link
Member

What does this change

  • Rename e2e to smoke tests. These should quickly (<3min) check that we didn't drastically break porter.
  • Always run the smoke tests for a pull request, but only run the integration tests when files related to the runtime changed.
  • You can manually run the integration tests with /azp run porter-integration
  • Only run the tests for canary releases. Maintainers tagging a release should always check canary is green first.

What issue does it fix

Closes #1546

Notes for the reviewer

I'd also like to see example bundle building split out too eventually.

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs
Copy link
Member Author

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@carolynvs
Copy link
Member Author

The default PR build is now 8 minutes, including time farting around waiting for an agent.

Screen Shot 2021-05-06 at 3 34 20 PM

@carolynvs carolynvs marked this pull request as ready for review May 6, 2021 20:42
@carolynvs
Copy link
Member Author

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Makes it easier to move tests w/o breaking file paths

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
paths:
include:
- build/azure-pipelines.integration.yaml
- tests/smoke/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of (or in addition to) including tests/smoke/*, would we want to include tests/integration/*?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yeah that was a brain fart. I'm glad you caught that!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. I know I have a tire fire of commits, so I will squash when we merge.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carolynvs carolynvs merged commit 40e7f85 into main May 10, 2021
@carolynvs carolynvs deleted the split-builds branch May 10, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up release process, aka I hate waiting
2 participants