Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix v1 build #1632

Merged
merged 7 commits into from
Jun 14, 2021
Merged

Fix v1 build #1632

merged 7 commits into from
Jun 14, 2021

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Jun 11, 2021 •
edited
Loading

This fixes a bunch of small problems that snuck into the v1 build:

  • The v1 integration tests were broken because they weren't compiling after a struct was renamed. I have updated test-unit so that it compiles (doesn't run) the integration tests so that we catch that problem quickly in a PR next time.
  • Remove unused target verify
  • Move test-unit into mage
  • The new cnab-go validation was validating things that it shouldn't (Do not validate unspecified optional paramters cnabio/cnab-go#262)
  • I see dead people but not typos
  • Do not use the branch name for the permalink when building pull requests, just use "dev"

@carolynvs
Fix integration tests
5db82d4 
A file was missed when  DisplayOutput was renamed to DisplayValue

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs
Improve build
0001653 
* Compile integration tests during test-unit so that we quickly catch
when we have plain broke the integration tests, since they aren't run
often.
* Remove unused target verify
* Move test-unit into mage

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs
Fix typo in makefile
177dc28 
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs
Copy link
Member Author

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs
Copy link
Member Author

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs
Fix bug with validation of params in cnab-go
c36dd43 
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs
Fix typo
a0bdb45 
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs
Use dev as the permalink for PR builds
84b85ce 
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs
Copy link
Member Author

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs carolynvs marked this pull request as ready for review June 14, 2021 15:32
@carolynvs
Copy link
Member Author

Since I was able to merge that cnab-go PR for validation, I'll do one more change to bump cnab-go to use the official repo instead of the fork I created while testing this PR.

vdice
vdice approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vdice vdice mentioned this pull request Jun 14, 2021
Closed
3 tasks
@carolynvs
Pin to latest cnab-go
bf7b568 
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs merged commit e748b8e into getporter:release/v1 Jun 14, 2021
@carolynvs carolynvs deleted the fix-build branch June 14, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdice vdice vdice approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carolynvs @vdice