Improve the schema command #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it easier to install just the porter binaries or just the mixins. This is useful when you are iterating on VS Code work and need to just drop in the porter binaries without messing up which mixins are installed.
When porter.json is present in PORTER_HOME, the porter schema command will return it, instead of generating a schema. This is intended to assist with troubleshooting VS Code. It will allow someone to tweak the schema without modifying porter or the mixins and quickly iterate inside of VS Code, and then we can update the Go code to match the desired schema later.
* When an error occurs generating a schema, return the template so that we at least have the basic schema available at all times. * When an error occurs injecting a mixin, always skip and continue to the next, never error out so that an out of date mixin doesn't cause the entire command to fail.
carolynvs
force-pushed
the
schema-robusto
branch
from
bfc04d8
to
790e94e
Compare
jeremyrickard
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add troubleshooting hook to porter schema
When porter.json is present in PORTER_HOME, the porter schema command will return it, instead of generating a schema. This is intended to assist with troubleshooting VS Code. It will allow someone to tweak the schema without modifying porter or the mixins and quickly iterate inside of VS Code, and then we can update the Go code to match the desired schema later.
Make porter schema more robust