Fix for Ad-Hoc Case Class producing Dynamic Queries #1000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #992
Problem
Whenever Ad-Hoc case classes are used, AST produces a Dynamic Query which should not be the case.
Solution
Add case for Ad-Hoc Case Class in Unliftables.
Notes
Please note that I also added a test to IsDynamicSpec which is supposed to test this functionality but the IsDynamic method will produce a 'false' (i.e. it thinks it's not dynamic) even when line 154 in Unliftables in commented out. I think IsDynamic doesn't work properly but not sure what to do about it.
Checklist
README.md
if applicable[WIP]
to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormat
to make sure that the source files are formatted@getquill/maintainers