Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quill-jdbc: support nested transaction calls #430

Merged
merged 1 commit into from
Jul 8, 2016
Merged

quill-jdbc: support nested transaction calls #430

merged 1 commit into from
Jul 8, 2016

Conversation

fwbrasil
Copy link
Collaborator

@fwbrasil fwbrasil commented Jul 8, 2016

Fixes #402

Problem

The jdbc context doesn't support nested transactions because each transactional call creates a new transaction.

Solution

Don't create a new transaction if the transaction call is already inside a transaction

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@jilen
Copy link
Collaborator

jilen commented Jul 8, 2016

👍

Approved with PullApprove

@fwbrasil
Copy link
Collaborator Author

fwbrasil commented Jul 8, 2016

👍

Approved with PullApprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants