pass ssl settings to async driver #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwbrasil
requested changes
Oct 9, 2016
| @@ -1285,6 +1286,7 @@ ctx.poolMaxQueueSize=4 | |||
| ctx.poolMaxObjects=4 | |||
| ctx.poolMaxIdle=999999999 | |||
| ctx.poolValidationInterval=100 | |||
| ctx.sslmode=disable # optional, one of [disable|prefer|require|verify-ca|verify-full] | |||
There was a problem hiding this comment.
could you add an example of sslrootcert as well?
| def sslProps = Map( | ||
| "sslmode " -> Try(config.getString("sslmode")).toOption, | ||
| "sslrootcert" -> Try(config.getString("sslrootcert")).toOption | ||
| ).collect { case (key, Some(value)) => key -> value } | ||
|
|
||
| def configuration = |
There was a problem hiding this comment.
Could you create a new unit test AsyncContextConfigSpec.scala and test this method?
|
sure, done |
|
@liorhar It seems that there are source files unformatted. Also, could you please rebase your branch? Github doesn't allow me to do it. |
liorhar
force-pushed
the
ssl-conn
branch
3 times, most recently
from
1d2139d
to
9528b45
Compare
|
sure. done |
fwbrasil
approved these changes
Oct 11, 2016
|
thanks @liorhar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #586
Problem
It's impossible to use the async driver with postgresql or mysql that require secure connection
Solution
Pass ssl properties to async conext config
Notes
I am not sure how can this change be unit tested
Checklist
README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormatto make sure that the source files are formatted@getquill/maintainers