Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't generate sqls with aggregation of tuples #915

Merged
merged 1 commit into from
Sep 23, 2017
Merged

Conversation

fwbrasil
Copy link
Collaborator

Problem

Quill translations aggregations of tuples using invalid syntax. For instance COUNT(a.i, a.j).

Solution

Render COUNT(*) instead.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@fwbrasil fwbrasil merged commit c8a949d into master Sep 23, 2017
@fwbrasil fwbrasil deleted the count-star branch September 23, 2017 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant