Return failed future instead of exception in cassandra async prepare #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwbrasil
reviewed
Dec 12, 2017
| .map(_.all.asScala.toList.map(extractor)) | ||
| } | ||
| def executeQuery[T](cql: String, prepare: Prepare = identityPrepare, extractor: Extractor[T] = identityExtractor)(implicit ec: ExecutionContext): Future[List[T]] = | ||
| Future(prepare(super.prepare(cql))) flatMap { |
There was a problem hiding this comment.
Could you avoid infix syntax? (.flatMap)
mosyp
force-pushed
the
fix-async-regres
branch
from
8132d6f
to
70b35d4
Compare
mosyp
force-pushed
the
fix-async-regres
branch
from
f4eb812
to
2d47a9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #993
Problem
I've introduced regression in https://github.com/getquill/quill/pull/813/files#diff-aaa78b79914a79908f7b9ab1e17e1e6eR30
Solution
fix it
Checklist
README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormatto make sure that the source files are formatted@getquill/maintainers