Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node6 #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove node6 #8

wants to merge 1 commit into from

Conversation

koooge
Copy link

@koooge koooge commented Dec 24, 2018

Hello ✋ . redash/base doesn't have to install node. refs getredash/redash#3199

@arikfr
Copy link
Member

arikfr commented Dec 24, 2018

Thanks!

We need to think how to handle this: currently all the old getredash/redash Dockerfiles reference redash/base:latest, which if we merge this will no longer have Node installed.

I think we should:

  1. Switch to versioned image references.
  2. Keep latest tag reference the old image until enough time passed and we can deprecate it.

@arikfr
Copy link
Member

arikfr commented Dec 24, 2018

Until I figure out how to build versions, let's keep this open.

Signed-off-by: koooge <koooooge@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants