Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a step to correct query IDs for queries using query_results #79

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Conversation

mvsleak
Copy link
Contributor

@mvsleak mvsleak commented Oct 18, 2021

Added a step to "remap" query IDs used as table names. It renames the table names correctly as long as the underlying queries have a mapping in meta.json (i.e. imported successfully)

Also made the error messages more verbose with exception messages, since without knowing them, migration troubleshooting can be hard...

Pardon the code quality :)

@susodapop susodapop self-assigned this Oct 18, 2021
@susodapop
Copy link
Collaborator

Thanks for this contribution @mvsleak . I've checked out the code locally for testing. I've got a few changes I'd like to make. Will aim to merge this in the next couple days and then cut a new release onto Pypi so people can pip install it 👍

@susodapop susodapop changed the base branch from master to qrds-refs October 21, 2021 21:39
@susodapop susodapop merged commit 92cf008 into getredash:qrds-refs Oct 21, 2021
@susodapop
Copy link
Collaborator

Since I didn't have push privileges on your fork, I merged this PR into a non-master branch on this repository. Then I opened #91 with a few adjustments. One that merges we'll merge the non-master branch into master.

@susodapop
Copy link
Collaborator

susodapop commented Oct 21, 2021

@mvsleak If you wouldn't mind having a look at the follow-up PR #91 I'd appreciate it 🙏

susodapop added a commit that referenced this pull request Oct 25, 2021
…ts (#93)

* Add a step to correct query IDs for queries using query_results (#79)
* Adjustments to match existing style of migrate.py (#91)

Co-authored-by: mvsleak <83390020+mvsleak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants