Fix: default predicate should be undefined and not empty string

getredash · Jan 14, 2014 · 4a15633 · 4a15633
1 parent 7e197d2
commit 4a15633
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/rd_ui/app/scripts/smart-table.js b/rd_ui/app/scripts/smart-table.js
@@ -15,7 +15,7 @@
         sortPredicate: '',
         formatFunction: '',
         formatParameter: '',
-        filterPredicate: '',
+        filterPredicate: undefined,
         cellTemplateUrl: '',
         headerClass: '',
         cellClass: ''
@@ -184,7 +184,7 @@
                 replace: false,
                 link: function (scope, element, attr, ctrl) {
 
-                    scope.searchValue = '';
+                    scope.searchValue = undefined;
 
                     scope.$watch('searchValue', function (value) {
                         //todo perf improvement only filter on blur ?
@@ -464,14 +464,13 @@
              * @param column
              */
             this.search = function (input, column) {
-
                 //update column and global predicate
                 if (column && scope.columns.indexOf(column) !== -1) {
                     predicate.$ = '';
                     column.filterPredicate = input;
                 } else {
                     for (var j = 0, l = scope.columns.length; j < l; j++) {
-                        scope.columns[j].filterPredicate = '';
+                        scope.columns[j].filterPredicate = undefined;
                     }
                     predicate.$ = input;
                 }