Remove --max-old-space-size=4096 from npm build command (#4381)

* Remove --max-old-space-size=4096 from build Looks like it's no longer needed. * Update to node v12. * Add build:old-node-version for those who have Node < 12.
getredash · Dec 5, 2019 · 7c05a73 · 7c05a73
1 parent 2633052
commit 7c05a73
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:10 as frontend-builder
+FROM node:12 as frontend-builder
 
 WORKDIR /frontend
 COPY package.json package-lock.json /frontend/

diff --git a/package.json b/package.json
@@ -7,7 +7,8 @@
     "start": "webpack-dev-server",
     "bundle": "bin/bundle-extensions",
     "clean": "rm -rf ./client/dist/",
-    "build": "npm run clean && NODE_ENV=production node --max-old-space-size=4096 node_modules/.bin/webpack",
+    "build": "npm run clean && NODE_ENV=production webpack",
+    "build:old-node-version": "npm run clean && NODE_ENV=production node --max-old-space-size=4096 node_modules/.bin/webpack",    
     "watch": "webpack --watch --progress --colors -d",
     "analyze": "npm run clean && BUNDLE_ANALYZER=on webpack",
     "analyze:build": "npm run clean && NODE_ENV=production BUNDLE_ANALYZER=on webpack",