Replace numeral with numbro (or another alternative)

[kravets-levko]

We use numeral package to format numbers in visualizations (and probably in some other places), but it wasn't updated for a quite long time, and seems it's owner don't plan to improve it. But sometimes we need features not supported by numeral - say, using escape sequences in format string.

There are other libraries similar to numeral which are more actively maintained, like numbro - which supports similar format syntax and can use escape sequences. numbro is my suggestion, however, some another library could be used as well (if it supports the same format syntax and escape sequences - in fact we don't use all that number manipulation stuff, only formatting).

[kravets-levko]

Added "Feature request" label because technically we need to replace the library in order to use new features (escape sequences in format string)

[morsedl]

+1

[rcoup]

https://discuss.redash.io/t/other-currency-types-in-tables/3356/4 links here to point out '£' doesn't work as a currency symbol.

Numbro's approach for currency formatting seems weird to me: if you call .formatCurrency() and your language is set to Japanese, it'll show ¥, but that makes the enormous assumption people only ever want to use their "local" currency in queries? Simpler: allow locale-based number formatting, but let the user put the appropriate currency symbol in the correct place? (eg. '£ 0.00')

[kravets-levko]

@rcoup The idea is not to use currency formatting abilities provided by numeral/numbro at all, instead letting user to just add arbitrary characters in format string(e.g. 0[.00] {USD}). This will allow to use different currency signs at any position, which is more flexible.

[vvohra87]

Any update on when this will be sorted out?

[zhongjiajie]

I'm not familiar with our codebase, but I find numeral key word in repo, https://github.com/getredash/redash/search?q=numeral&type=Code and only 5 match. So the point is numbro not 100% compatible with numeral?