Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts: Korean characters in default template misbehave #4611

Closed
susodapop opened this issue Feb 5, 2020 · 1 comment · Fixed by #4627
Closed

Alerts: Korean characters in default template misbehave #4611

susodapop opened this issue Feb 5, 2020 · 1 comment · Fixed by #4627

Comments

@susodapop
Copy link
Contributor

Issue Summary

Alert titles that contain Korean or Japanese characters are badly encoded if the default alert email template is used. The custom alert templates do not appear so affected.

Steps to Reproduce

  1. Make a query that returns logical data: SELECT 1 "foo";
  2. Point an alert at this query that asserts foo == 2
  3. Name the alert 숨 쉬는 법을 모르겠다
  4. Save the alert and add your email as an alert destination
  5. Trigger the query

You will receive an email with the following subject:

(TRIGGERED) b'\xec\x88\xa8 \xec\x89\xac\xeb\x8a\x94 \xeb\xb2\x95\xec\x9d\x84 \xeb\xaa\xa8\xeb\xa5\xb4\xea\xb2\xa0\xeb\x8b\xa4'

You can workaround this using the custom template. The custom template properly encodes Korean and Japanese characters.

Technical details:

  • Redash Version: V9
  • Browser/OS: FF
  • How did you install Redash: SaaS
@susodapop
Copy link
Contributor Author

Arik merged a fix in the SaaS repo. I'm closing this here so our customer service integration will surface the users affected on app.redash.io so I can follow up with them. I'll re-open afterward so that @arikfr can close it when the changes merge to master on this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant