Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard editing permissions not working #4612

Closed
susodapop opened this issue Feb 5, 2020 · 1 comment · Fixed by #4613
Closed

Dashboard editing permissions not working #4612

susodapop opened this issue Feb 5, 2020 · 1 comment · Fixed by #4613

Comments

@susodapop
Copy link
Contributor

Issue Summary

Suppose user A shares dashboard edit permissions with user B. When user B visits the dashboard, there is no edit button. User B also can't make a POST api call with changes.

Steps to Reproduce

  1. Ensure the permissions feature flag is ticked.
  2. Share dashboard edit permissions with another user
  3. Observe the other user does not have an edit button when visiting the dashboard.

Technical details:

  • Redash Version: V9
  • Browser/OS: FF & API client
  • How did you install Redash: SaaS
@gabrieldutra
Copy link
Member

@susodapop, I tested in here, it looks like it's a frontend only issue as I could edit a dashboard with no problems after changing how the check is made on the page (will open a PR, so you can confirm it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants