Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query View design follow ups #4663

Closed
4 tasks done
arikfr opened this issue Feb 19, 2020 · 0 comments · Fixed by #4699
Closed
4 tasks done

Query View design follow ups #4663

arikfr opened this issue Feb 19, 2020 · 0 comments · Fixed by #4699
Assignees
@arikfr
Labels
Frontend UX
Milestone
v9

Comments

@arikfr
Copy link
Member

arikfr commented Feb 19, 2020 •
edited by susodapop
Loading

Follow ups for #4536:

  • The Data Source and Refresh Schedule fields are unaligned. Data Source has height of 30px (because of icon) while Refresh Schedule has height of 28px.
  • The execution status is closer to the lower border than the upper one, need to center it.
  • On Mobile we need to make the header more like the design: while we decided to drop the "Add Tag"/"Add Description" buttons, we still should move the other action buttons to a separate row + have the tags on a separate row (if they exist).
  • Update text of empty state @arikfr

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arikfr arikfr

Labels
Frontend UX
Projects
None yet
Milestone
v9
Development

Successfully merging a pull request may close this issue.

Query page: update empty state text getredash/redash
2 participants
@arikfr @gabrieldutra