Fix there's no publish button on mobile query page #4760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: I decided to proceed with "If you think there are too many buttons on mobile version it's also possible to move the Publish button to the dropdown." as it looked to me the Query View buttons could overflow on smaller mobile screens (the view page has the "Refresh" button too). So the result is now:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Reported by @susodapop, the Publish Button was removed during the Query Page migration since there was too many buttons and it was breaking the width layout. But since #4663 the buttons wrap in a new row, so we can fit the Publish button back.
If you think there are too many buttons on mobile version it's also possible to move the Publish button to the dropdown.
Related Tickets & Documents
--
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Query View
Query Source