Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't click-to-collapse the tag picker modal #4833

Open
susodapop opened this issue Apr 24, 2020 · 0 comments
Open

Can't click-to-collapse the tag picker modal #4833

susodapop opened this issue Apr 24, 2020 · 0 comments

Comments

@susodapop
Copy link
Contributor

Issue Summary

The tag picker is hard to close. It's impossible to tab to the OK button after picking tags with mouse or keyboard. Pressing Esc drops the selected tags. And clicking the <select> box itself has no effect. Only by clicking some white space in the modal can you reveal the OK and Cancel buttons.

tag demo

Steps to Reproduce

  1. Open the tag modal
  2. Add some tags
  3. Observe that the OK and Cancel buttons are hidden by the dropdown with no obvious way to collapse it.

Clicking the <select> tag elsewhere in the app will collapse its drop down. But the behavior isn't consistently available. On the visualization editor the X-axis field picker can click-to-collapse but the Y-axis field picker can't, for example.

demo

How to fix

Make the tag picker collapse/expand when clicked. Or change the tag picker so its OK and Cancel buttons are always visible. Here's how Intercom does it.

ideal

Technical details:

  • Redash Version: V9 alpha
  • Browser/OS: FF
  • How did you install Redash: SaaS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant