Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ?embed-related code in public dashboards #2226

Merged
merged 1 commit into from
Jan 17, 2018
Merged

Remove ?embed-related code in public dashboards #2226

merged 1 commit into from
Jan 17, 2018

Conversation

kravets-levko
Copy link
Collaborator

Issue #1940

@kravets-levko
Copy link
Collaborator Author

I spent some time on backend code - seems that there is no code related to embed param except of this line which just records an event - I think we should keep it because some URLs with embed param may already exist.

@arikfr arikfr merged commit dcf867e into getredash:master Jan 17, 2018
@kravets-levko kravets-levko deleted the feature/dashboard-remove-embed-related-code branch February 11, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants