User shouldn't be able to change the type of the first table #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Feb 18, 2018
| this.canChangeType = !( | ||
| (this.visualization.type === 'TABLE') && | ||
| (this.visualization.id === min(pluck(this.query.visualizations, 'id'))) | ||
| ); |
There was a problem hiding this comment.
Maybe a simpler solution will be to not let the user change type after creating the visualization? I don't see much reason for a user to change type after creation and it will make it less of a guess work here :)
There was a problem hiding this comment.
Hm, makes sense. Will do 👍
There was a problem hiding this comment.
I'm not sure if I understand the intention behind the revised logic. Could you please explain? Because if I understand correctly, I think the revised logic is more complex and difficult to discover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2312