-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable fork button for view_only user #2472
Disable fork button for view_only user #2472
Conversation
@@ -29,10 +29,12 @@ | |||
|
|||
&:not([class*="bg-"]) { | |||
& > li > a { | |||
color: #4C4C4C; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tonyjiangh I think, this is a better place for this CSS. @kocsmy - WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition - there is a variable for disabled dropdown items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we have a disabled class for li already. We'll need to adjust the color a bit more gray to indicate it's disabled.
Thanks! Why disable it (for creator/admin) in data only mode? |
@arikfr As I see, @tonyjiangh didn't implement any new logic - he uses the same condition ( |
@kravets-levko @arikfr @kravets-levko It thought this was intentional. But based on the conversation above, I guess it's not. I'll fix that too. |
Before/After
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks! |
Fix #2459
Disabled view
With cursor disabled as well
Before/AfterTested over Firefox 59.0.2