Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert page - migrate to React and redesign #4153

Merged
merged 14 commits into from
Oct 7, 2019
Merged

Alert page - migrate to React and redesign #4153

merged 14 commits into from
Oct 7, 2019

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Sep 19, 2019 •
edited
Loading

This is the first part of a handful of PRs.

  • Refactor
  • Feature

Description

  1. Migration to React
  2. Front end redesign status, criteria, rearm, edit/view modes and more.

Feature list

Create alert
Screen Shot 2019-09-19 at 19 36 20

And select query
Screen Shot 2019-09-19 at 19 36 46

View mode
Screen Shot 2019-09-19 at 19 37 58

   
Statuses Screen Shot 2019-09-19 at 19 38 23 Screen Shot 2019-09-19 at 19 39 20 Screen Shot 2019-09-19 at 19 39 00
Query edit Screen Shot 2019-09-19 at 19 41 23
Query view Screen Shot 2019-09-19 at 19 40 01
No sched Screen Shot 2019-09-19 at 19 40 18
Criteria edit Screen Shot 2019-09-19 at 19 41 57
Data errors Screen Shot 2019-09-19 at 19 43 08 Screen Shot 2019-09-19 at 19 43 21
Criteria view Screen Shot 2019-09-19 at 19 40 39
Rearm edit Screen Shot 2019-09-19 at 19 43 46
At most every ... Screen Shot 2019-09-19 at 19 44 05
Rearm view Screen Shot 2019-09-19 at 19 40 46
Save / cancel / Delete Screen Shot 2019-09-19 at 19 44 46

More features:

  • Users with no edit permissions on specific alert get the view version always.
  • Criteria allows comparing strings with "equals".

@ranbena ranbena self-assigned this Sep 19, 2019
@ranbena ranbena mentioned this pull request Sep 19, 2019
Merged
2 tasks
@arikfr arikfr mentioned this pull request Sep 20, 2019
Closed
@ranbena ranbena marked this pull request as ready for review September 22, 2019 17:19
@arikfr arikfr mentioned this pull request Sep 23, 2019
Closed
12 tasks
@weekly-digest weekly-digest bot mentioned this pull request Sep 23, 2019
Closed
kravets-levko
kravets-levko approved these changes Sep 23, 2019
View reviewed changes
Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few notices, nothing critical though 👍

client/app/assets/less/inc/base.less Outdated Show resolved Hide resolved
client/app/pages/alert/Alert.jsx Show resolved Hide resolved
client/app/pages/alert/Alert.jsx Outdated Show resolved Hide resolved
@weekly-digest weekly-digest bot mentioned this pull request Sep 30, 2019
Closed
@weekly-digest weekly-digest bot mentioned this pull request Oct 7, 2019
Closed
@ranbena ranbena mentioned this pull request Oct 7, 2019
Closed
6 tasks
@arikfr arikfr mentioned this pull request Oct 7, 2019
Closed
@ranbena @arikfr
Separated Alert to View / Edit / New page components (#4183)
be404a4 
* Separated Alert to View / Edit / New page components

* Moved query result loader into <Query />

* Added missing Query prop

* No reload for edit / view / new state changes

* Added warn and tooltip when non-editable

* Rebased
@arikfr arikfr changed the title Alert redesign #1 - React and redesign Alert page - migrate to React and redesign Oct 7, 2019
@ranbena ranbena merged commit 69dc761 into master Oct 7, 2019
@ranbena ranbena deleted the alert-1 branch October 7, 2019 16:15
@ranbena ranbena mentioned this pull request Oct 12, 2019
Open
4 tasks
@weekly-digest weekly-digest bot mentioned this pull request Oct 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr arikfr left review comments

@kravets-levko kravets-levko kravets-levko approved these changes

@gabrieldutra gabrieldutra Awaiting requested review from gabrieldutra

Assignees

@ranbena ranbena

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ranbena @arikfr @kravets-levko