Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust botocore dependency, so we don't need to update it as often #4154

Merged
merged 1 commit into from Oct 6, 2019
Merged

Adjust botocore dependency, so we don't need to update it as often #4154

merged 1 commit into from Oct 6, 2019

Conversation

justinclift
Copy link
Member

@justinclift justinclift commented Sep 19, 2019 •
edited

What type of PR is this? (check all applicable)

  • Bug Fix

Description

Updated botocore again, as boto3 now requires the latest release (v1.12.239).

With this PR, in theory we shouldn't need to update it manually in future all that much. Hopefully. 馃槃

Without this change, installation gives the following error:

boto3 1.9.231 has requirement botocore<1.13.0,>=1.12.239, but you'll have
botocore 1.12.220 which is incompatible.

@weekly-digest weekly-digest bot mentioned this pull request Sep 23, 2019
Closed
@yujunz yujunz mentioned this pull request Sep 27, 2019
Closed
arikfr
arikfr reviewed Oct 1, 2019
View reviewed changes
Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be on the safe side, added an upper limit to the version.

requirements_all_ds.txt Outdated Show resolved Hide resolved
requirements_dev.txt Outdated Show resolved Hide resolved
@justinclift
Copy link
Member Author

Updated. Should be good to go now. 馃槃

@arikfr arikfr merged commit 0a5dca5 into getredash:master Oct 6, 2019
@arikfr
Copy link
Member

arikfr commented Oct 6, 2019

馃憤

@justinclift justinclift deleted the botocore_231 branch October 6, 2019 14:04
@weekly-digest weekly-digest bot mentioned this pull request Oct 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr arikfr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justinclift @arikfr