Fix query based dropdown not adding quote marks correctly #4186
Conversation
There was a problem hiding this comment.
The issue seemed to be caused due to some inconsistencies in the structure (e.g: Not having an array in the value when it should). The difference from the regular Dropdown parameter is that its options are known from the structure of the parameter, so it's possible to normalize the value from the setValue method.
Considering that, I now just make sure it's always an array from the Parameter structure and improved the value handling in the input. @ranbena @kravets-levko lmk if you have other ideas (imo ideally we should have access to the options in the parameter structure, but I don't think an async request in there is a good thing 😅).
| } | ||
| } | ||
|
|
||
| setValue(value) { |
There was a problem hiding this comment.
Now using a value from state + this method to make sure no invalid values will go to the Select component.
| @@ -387,7 +393,8 @@ export class Parameter { | |||
| if (has(query, key)) { | |||
| if (this.multiValuesOptions) { | |||
| try { | |||
| this.setValue(JSON.parse(query[key])); | |||
| const valueFromJson = JSON.parse(query[key]); | |||
| this.setValue(isArray(valueFromJson) ? valueFromJson : query[key]); | |||
There was a problem hiding this comment.
Turns out numbers are also parsed and converted 😅, so this makes sure we don't convert it unless it's an array.
| @@ -253,6 +253,12 @@ export class Parameter { | |||
| } | |||
| } | |||
|
|
|||
| if (this.type === 'query' && !isEmptyValue(value)) { | |||
| if (this.multiValuesOptions && !isArray(value) && value !== null) { | |||
| value = [value]; | |||
There was a problem hiding this comment.
QueryBasedDropdown with multi-values should always hold array values in its structure.
|
🐛 |
What type of PR is this? (check all applicable)
Description
This is not perfect yet, I still wanna explore a few more options without having the Dropdown Options in the Parameter structure context (that's the only difference from the regular Dropdown code - what handles if the value is valid is the Input).
Related Tickets & Documents
Fixes #4184
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
--