Multiprocess RQ workers (using supervisor) #4371
Conversation
bin/docker-entrypoint
Outdated
| export WORKERS_COUNT=${WORKERS_COUNT:-2} | ||
| export QUEUES=${QUEUES:-} | ||
|
|
||
| touch /tmp/worker.log && tail -f /tmp/worker.log & |
There was a problem hiding this comment.
Is there a reason you didn't configure supervisord to write to stdout directly?
There was a problem hiding this comment.
That's even simpler :) didn't think of that! 1fb1a7e handles this.
worker.conf
Outdated
| @@ -0,0 +1,17 @@ | |||
| [supervisord] | |||
| logfile=/tmp/supervisord.log | |||
There was a problem hiding this comment.
Need to update this to stdout as well.
In 092eb6c I've used supervisor_checks to run a check every minute (we should probably change the interval) - the check runs for every monitored process and asserts that the worker is behaving as expected (on top of what you get from supervisor, which is basically testing if the process is up). If a specific worker process is misbehaving, it is replaced. We can also add more checks for CPU / memory (provided OOTB by supervisor_checks) Let me know what you think of this. |
|
@arikfr can we merge this? |
What type of PR is this? (check all applicable)
Description
This is an alternative implementation to the one suggested in #4233. Here we use
supervisorinstead ofHonchoin order to spin up, monitor and restart multiple worker processes.supervisor is installed in the Docker image and is launched inside the
workerentrypoint. We use the non-daemonized mode of supervisor in order to allow the container to exit in case the supervisor process exits.Related Tickets & Documents
#4233