New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map: add tooltip and popup templating #4443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks fine, good work!
Two more suggestions:
- I think tooltip/popup inputs need some placeholder that will tell user that default template will be used. It may even use that default template as a placeholder. Also, the same should be mentioned in context help tooltip (e.g. "Leave this field empty to use default template").
- WDYT about using markdown instead of plain HTML for templates?
tooltip is fine, but popup is an issue. Default value is something impossible to recreate in simple HTML. We would need some kind of template engine that can iterate over a list.
I assumed markdown cannot handle image layout very well, but I guess you can align images to the left etc. these days. There was a discussion of which library to use in #3170. Are we going with mustache #3776? |
1 - let's add a "Leave this field empty to use default template" text to 2 - noticed that Choropleth does not use markdown as well 😅 Let's keep it as is 👍 |
@kravets-levko, I've added placeholder, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟
What type of PR is this? (check all applicable)
Description
Adds feature to define your own tooltip and popup format for Map Visualization
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)