-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query View redesign #4536
Merged
Merged
Query View redesign #4536
Commits on Jan 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 099d58f - Browse repository at this point
Copy the full SHA 099d58fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4338bf - Browse repository at this point
Copy the full SHA b4338bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 981fd87 - Browse repository at this point
Copy the full SHA 981fd87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f10646 - Browse repository at this point
Copy the full SHA 2f10646View commit details -
Configuration menu - View commit details
-
Copy full SHA for 710def1 - Browse repository at this point
Copy the full SHA 710def1View commit details -
- background color slightly different - use link for New Visualization
Configuration menu - View commit details
-
Copy full SHA for 475bebf - Browse repository at this point
Copy the full SHA 475bebfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7132727 - Browse repository at this point
Copy the full SHA 7132727View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7074f8 - Browse repository at this point
Copy the full SHA d7074f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b12727e - Browse repository at this point
Copy the full SHA b12727eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d37058 - Browse repository at this point
Copy the full SHA 6d37058View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1424bad - Browse repository at this point
Copy the full SHA 1424badView commit details -
Configuration menu - View commit details
-
Copy full SHA for afa4159 - Browse repository at this point
Copy the full SHA afa4159View commit details -
Configuration menu - View commit details
-
Copy full SHA for a86ceda - Browse repository at this point
Copy the full SHA a86cedaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 872719f - Browse repository at this point
Copy the full SHA 872719fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0b1a64 - Browse repository at this point
Copy the full SHA a0b1a64View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3a55bd - Browse repository at this point
Copy the full SHA e3a55bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4f0d29 - Browse repository at this point
Copy the full SHA a4f0d29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bc17ce - Browse repository at this point
Copy the full SHA 6bc17ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc59a0e - Browse repository at this point
Copy the full SHA dc59a0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 88eb1d3 - Browse repository at this point
Copy the full SHA 88eb1d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef677c2 - Browse repository at this point
Copy the full SHA ef677c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d64b802 - Browse repository at this point
Copy the full SHA d64b802View commit details
Commits on Feb 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3ff8ec8 - Browse repository at this point
Copy the full SHA 3ff8ec8View commit details
Commits on Feb 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9f923af - Browse repository at this point
Copy the full SHA 9f923afView commit details
Commits on Feb 19, 2020
-
Refactor useQueryExecution & add inline query execution status (#4584)
* QueryResult: added support for getting status updates using a callback instead of polling on the query result status. This is a step towards bigger refacotr. We should completly rewrite this class and split it into two: 1. QueryExecution -- executes a query and tracks status. 2. QueryResult -- represents the actual QueryResult and has the different utilities to use the results (although those might be moved into helpers). * Refactor useQueryExecution. * useQueryExecution: only consider last triggered execution * Fix execution triggered on every query update * Add loadedInitialResults and fix loading results issues * Only show Add Vis button when results are done * Don't show notification on first results load * Remove unnecessary useEffect * Add margin between text and cancel button * Add Refresh button to QuerySource * Update ExecutionStatus positioning * Mobile updates * Add more spacing for execution status in mobile * Add spacing between results wrapper and resizer * Align Query description * Hide Add Description/tag on mobile * Allow different messages for no results/empty set * Don't show empty state when opening new query page * Add min-width to ExecutionStatus * Improve ExecutionStatus spacing * Use same execution information for view/edit * Use autoFocus in EditInPlace for focus - remove inputRef and use autoFocus attr * Control visualization row emptyState from Renderer * Fix broken Filters on Visualization Renderer * Don't handle empty state based on context * Add Data Source label to data source. * Reuse useFullscreenHandler in QueryView page. * (style fix) Co-authored-by: Gabriel Dutra <nesk.frz@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c6936a1 - Browse repository at this point
Copy the full SHA c6936a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fd1819 - Browse repository at this point
Copy the full SHA 7fd1819View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.