Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query View redesign #4536

Merged
merged 26 commits into from
Feb 19, 2020
Merged

Query View redesign #4536

merged 26 commits into from
Feb 19, 2020

Commits on Jan 22, 2020

  1. Configuration menu
    Copy the full SHA
    099d58f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b4338bf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    981fd87 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2f10646 View commit details
    Browse the repository at this point in the history
  5. Add Parameters container

    gabrieldutra authored and arikfr committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    710def1 View commit details
    Browse the repository at this point in the history
  6. Small details

    - background color slightly different
    - use link for New Visualization
    gabrieldutra authored and arikfr committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    475bebf View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7132727 View commit details
    Browse the repository at this point in the history
  8. Adjust Tabs details

    gabrieldutra authored and arikfr committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    d7074f8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b12727e View commit details
    Browse the repository at this point in the history
  10. Add fullscreen data toggle

    gabrieldutra authored and arikfr committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    6d37058 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    1424bad View commit details
    Browse the repository at this point in the history
  12. Non-fixed layout for mobiles

    gabrieldutra authored and arikfr committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    afa4159 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a86ceda View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    872719f View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    a0b1a64 View commit details
    Browse the repository at this point in the history
  16. Remove margin from Query Header

    gabrieldutra authored and arikfr committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    e3a55bd View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    a4f0d29 View commit details
    Browse the repository at this point in the history
  18. Use width 100% instead of 100vw

    gabrieldutra authored and arikfr committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    6bc17ce View commit details
    Browse the repository at this point in the history
  19. Add Visualization Button

    gabrieldutra authored and arikfr committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    dc59a0e View commit details
    Browse the repository at this point in the history
  20. Add EmptyState

    gabrieldutra authored and arikfr committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    88eb1d3 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    ef677c2 View commit details
    Browse the repository at this point in the history
  22. Sync with master.

    arikfr committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    d64b802 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2020

  1. Configuration menu
    Copy the full SHA
    3ff8ec8 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2020

  1. Configuration menu
    Copy the full SHA
    9f923af View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2020

  1. Refactor useQueryExecution & add inline query execution status (#4584)

    * QueryResult: added support for getting status updates using a callback instead of polling on the query result status.
    
    This is a step towards bigger refacotr. We should completly rewrite this class and split it into two:
    
    1. QueryExecution -- executes a query and tracks status.
    2. QueryResult -- represents the actual QueryResult and has the different utilities to use the results (although those might be moved into helpers).
    
    * Refactor useQueryExecution.
    
    * useQueryExecution: only consider last triggered execution
    
    * Fix execution triggered on every query update
    
    * Add loadedInitialResults and fix loading results issues
    
    * Only show Add Vis button when results are done
    
    * Don't show notification on first results load
    
    * Remove unnecessary useEffect
    
    * Add margin between text and cancel button
    
    * Add Refresh button to QuerySource
    
    * Update ExecutionStatus positioning
    
    * Mobile updates
    
    * Add more spacing for execution status in mobile
    
    * Add spacing between results wrapper and resizer
    
    * Align Query description
    
    * Hide Add Description/tag on mobile
    
    * Allow different messages for no results/empty set
    
    * Don't show empty state when opening new query page
    
    * Add min-width to ExecutionStatus
    
    * Improve ExecutionStatus spacing
    
    * Use same execution information for view/edit
    
    * Use autoFocus in EditInPlace for focus
    - remove inputRef and use autoFocus attr
    
    * Control visualization row emptyState from Renderer
    
    * Fix broken Filters on Visualization Renderer
    
    * Don't handle empty state based on context
    
    * Add Data Source label to data source.
    
    * Reuse useFullscreenHandler in QueryView page.
    
    * (style fix)
    
    Co-authored-by: Gabriel Dutra <nesk.frz@gmail.com>
    arikfr and gabrieldutra committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    c6936a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7fd1819 View commit details
    Browse the repository at this point in the history