Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RQ: Keep Job object of query execution for longer period of time #4559

Merged
merged 1 commit into from
Feb 9, 2020
Merged

RQ: Keep Job object of query execution for longer period of time #4559

merged 1 commit into from
Feb 9, 2020

Conversation

rauchy
Copy link
Contributor

@rauchy rauchy commented Feb 8, 2020

We need to keep jobs for longer, as people can execute a query, close the machine, come back and it shouldn't fail.

Also, in case the job isn't found, we should return proper message instead of currently the server blowing up.

@arikfr arikfr added the Backend label Jan 19, 2020
@arikfr arikfr added this to To do in Switch from Celery to RQ via automation Jan 19, 2020
@weekly-digest weekly-digest bot mentioned this pull request Jan 20, 2020
Closed
@rauchy rauchy moved this from To do to In progress in Switch from Celery to RQ Feb 3, 2020
@arikfr
Copy link
Member Author

arikfr commented Feb 9, 2020

Please rebase with master, so we can rule out failures due to #4617.

@rauchy rauchy force-pushed the keep-adhoc-job-results-for-longer branch from 81c6052 to 678835c Compare February 9, 2020 09:42
@rauchy
Copy link
Contributor

rauchy commented Feb 9, 2020

Please rebase with master, so we can rule out failures due to #4617.

Why would #4617 make a difference here?

@arikfr
Copy link
Member Author

arikfr commented Feb 9, 2020

Because it prevents running tests.

arikfr
arikfr reviewed Feb 9, 2020
View reviewed changes
Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rauchy rauchy merged commit 7edac9c into master Feb 9, 2020
Switch from Celery to RQ automation moved this from In progress to Done Feb 9, 2020
@rauchy rauchy deleted the keep-adhoc-job-results-for-longer branch February 9, 2020 10:29
@weekly-digest weekly-digest bot mentioned this pull request Feb 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr arikfr left review comments

Assignees

@rauchy rauchy

Labels
Backend
Projects
No open projects
Switch from Celery to RQ
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rauchy @arikfr