Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix treasuredata endpoint #4582

Merged
merged 3 commits into from
Feb 9, 2020
Merged

Fix treasuredata endpoint #4582

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66025a2
fix treasuredata endpoint
Jan 23, 2020
ff3ae60
make endpoint as a required
mickeey2525 Jan 24, 2020
214371a
fix unneccessart required parameter
mickeey2525 Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion redash/query_runner/treasuredata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def get_schema(self, get_stats=False):
schema = {}
if self.configuration.get("get_schema", False):
try:
with tdclient.Client(self.configuration.get("apikey")) as client:
with tdclient.Client(self.configuration.get("apikey"),endpoint=self.configuration.get("endpoint")) as client:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If endpoint isNone it will use the default value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, default parameter(https://api.treasuredata.com) is used

for table in client.tables(self.configuration.get("db")):
table_name = "{}.{}".format(
self.configuration.get("db"), table.name
Expand Down