Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct logger when enqueuing a query execution. #4614

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Feb 6, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Previously this was using the default logger instance which made things
harder to debug in production.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@jezdez jezdez requested review from rauchy and arikfr February 6, 2020 10:44
@jezdez
Copy link
Member Author

jezdez commented Feb 6, 2020

FTR, the logger was already used when actually executing the query.

@jezdez
Copy link
Member Author

jezdez commented Feb 6, 2020

@rauchy Sorry, I just found more of the same in other task modules.

@jezdez jezdez merged commit b089f5f into master Feb 6, 2020
@jezdez jezdez deleted the use-correct-logger branch February 6, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants