Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: encode/decode bytestring for base64. #4624

Merged
merged 2 commits into from
Feb 9, 2020
Merged

Fix: encode/decode bytestring for base64. #4624

merged 2 commits into from
Feb 9, 2020

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Feb 9, 2020

What type of PR is this? (check all applicable)

  • Bug Fix

Description

Residue of the Python 3 migration: correctly generate Base64 string.

Related Tickets & Documents

Closes #4621.

@arikfr arikfr requested a review from rauchy February 9, 2020 10:28
rauchy
rauchy reviewed Feb 9, 2020
View reviewed changes
Copy link
Contributor

@rauchy rauchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps this is an opportunity to extract and reuse the Hive-based _get_connection stuff? (They only differ by port and Databrick's token as username)

@arikfr arikfr merged commit f215947 into master Feb 9, 2020
@arikfr arikfr deleted the db-python3 branch February 9, 2020 11:42
@weekly-digest weekly-digest bot mentioned this pull request Feb 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauchy rauchy rauchy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Databricks Data Source Broken
2 participants
@arikfr @rauchy