Add newrelic query runner #5708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in counter visualization
|
@susodapop hey can someone please review and let me know if thing needs to be changed. |
|
Thanks for the PR @mudasirmirza. Just catching up here so thank you also for the ping. I'm excited to get suppport for NewRelic merged in. But to keep things isolated, can you please separate your front-end counter visualisation change into a separate PR? It's our policy that each commit to the Please ping me on both PR's once you're done. Thanks! |
This was referenced Mar 3, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adding NewRelic query runner. This support two types of queries, count and comparison.
Added %change in the Counter visualization (as I am not an expert in frontend, I did the best I could)
Related Tickets & Documents
Documentation will be updated on the KB under data sources
Mobile & Desktop Screenshots/Recordings (if there are UI changes)