Feature: download results in Excel (XSLX) format (closes #801) #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sheet = book.add_worksheet("result") | ||
| logging.info(query_data['columns']) | ||
|
|
||
| list = [] |
There was a problem hiding this comment.
list is a builtin function in Python. Better to name it with a different name, maybe columns_list?
|
@ninneko thanks! This is a great addition. |
arikfr
changed the title
|
Awesome 😊 |
added 2 commits
February 16, 2016 10:56
schedule = "{:02d}:00".format(now.hour - 3) maybe be negative value when now.hour < 3.
I've fixed it.
|
Thank you for reviews. |
arikfr
added a commit
that referenced
this pull request
Feb 16, 2016
Feature: download results in Excel (XSLX) format (closes #801)
|
Merged. Thank you for this great feature! (and for fixing the bug in tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add download excel button at query result view.