CLI: Restore ability to pass JSON options string for a new data source #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit "Encapsulate data source/query runner configuration in an object." (ed99b84) accidentally removed that functionality by not inflating the passed in JSON into a ConfigurationContainer object. This led to errors of the form if you passed -o: Traceback (most recent call last): ... File "/opt/redash/redash-git/redash/models.py", line 321, in db_value return value.to_json() AttributeError: 'unicode' object has no attribute 'to_json'
arikfr
added a commit
that referenced
this pull request
Mar 6, 2016
CLI: Restore ability to pass JSON options string for a new data source
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit "Encapsulate data source/query runner configuration in an
object." (ed99b84) accidentally removed that functionality by not
inflating the passed in JSON into a ConfigurationContainer object.
This led to errors of the form if you passed -o: