Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Restore ability to pass JSON options string for a new data source #882

Merged
merged 1 commit into from Mar 6, 2016

Commits on Mar 4, 2016

  1. CLI: Restore ability to pass JSON options string for a new data source

    Commit "Encapsulate data source/query runner configuration in an
    object." (ed99b84) accidentally removed that functionality by not
    inflating the passed in JSON into a ConfigurationContainer object.
    
    This led to errors of the form if you passed -o:
    
        Traceback (most recent call last):
          ...
          File "/opt/redash/redash-git/redash/models.py", line 321, in db_value
    	return value.to_json()
        AttributeError: 'unicode' object has no attribute 'to_json'
    tsibley committed Mar 4, 2016
    Configuration menu
    Copy the full SHA
    d07bf7e View commit details
    Browse the repository at this point in the history