rust: add more rust logging #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Apr 9, 2024
| @@ -505,6 +515,7 @@ mod tests { | |||
| impl AssignmentCallbacks for EmptyCallbacks { | |||
| fn on_assign(&self, partitions: HashMap<Partition, u64>) { | |||
| println!("assignment event: {:?}", partitions); | |||
|
|
|||
anonrig
reviewed
Apr 9, 2024
| @@ -628,6 +628,11 @@ def close(self, timeout: Optional[float] = None) -> None: | |||
| def closed(self) -> bool: | |||
| return self.__state is KafkaConsumerState.CLOSED | |||
|
|
|||
| @property | |||
| def member_id(self) -> str: | |||
There was a problem hiding this comment.
Maybe we should also add @cached_property, depending on the cost?
Suggested change
| def member_id(self) -> str: | |
| @cached_property | |
| def member_id(self) -> str: |
There was a problem hiding this comment.
I think it cheap. Also, I believe the member id changes depending on the rebalancing strategy used. So caching might be inacurate.
anonrig
approved these changes
Apr 9, 2024
Swatinem
approved these changes
Apr 10, 2024
lynnagara
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more logging to rust to more closely match python. Specifically, we add logging to show when the processor is terminating or closing/rejoining strategies.
We also introduce logging to show the member id as supplied by the broker. This is useful for debugging issue related to rebalancing in kafka since the broker logs only show member id.