Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade(@google-cloud/storage): ^5.7.0 #157

Merged
merged 1 commit into from Jan 5, 2021
Merged

upgrade(@google-cloud/storage): ^5.7.0 #157

merged 1 commit into from Jan 5, 2021

Conversation

BYK
Copy link
Contributor

@BYK BYK commented Jan 5, 2021

This is to upgrade the vulnerable axios dependency. The latest version has the following breaking changes which are all okay:

This is to upgrade the vulnerable `axios` dependency. The latest version has the following breaking changes which are all okay:

- automatically detect contentType if not provided (googleapis/nodejs-storage#1190)
- drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166)
- drop support for node.js 8.x
- allow leading slashes in file name (googleapis/nodejs-storage#820)
- upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)
@BYK BYK requested review from jan-auer and tonyo January 5, 2021 11:47
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that this is covered in tests 👍

@BYK BYK merged commit 0751ea1 into master Jan 5, 2021
@BYK BYK deleted the byk/upgrade/gcs branch January 5, 2021 11:59
@BYK BYK mentioned this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants