Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: upgrade engines field to >=8.10.0 #688

Merged
merged 2 commits into from
May 2, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 2, 2019

This drops support for all Node.js versions < 8.10.0, please upgrade

BREAKING CHANGE: library now requires Node >= 8.10.0

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2019
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #688 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #688   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files           9        9           
  Lines        1138     1138           
  Branches      292      292           
=======================================
  Hits         1101     1101           
  Misses          9        9           
  Partials       28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1135020...c11bbf8. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 6a1fa0f into master May 2, 2019
@JustinBeckwith JustinBeckwith deleted the update-engine-field-2-the-updates-revenge branch May 2, 2019 18:31
BYK added a commit to getsentry/sentry-javascript that referenced this pull request Jan 4, 2021
This is to upgrade the vulnerable `date-and-time` dependency. The latest version has the following breaking changes which are all okay:

- automatically detect contentType if not provided (googleapis/nodejs-storage#1190)
- drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166)
- drop support for node.js 8.x
- allow leading slashes in file name (googleapis/nodejs-storage#820)
- upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)
BYK added a commit to getsentry/craft that referenced this pull request Jan 5, 2021
This is to upgrade the vulnerable `axios` dependency. The latest version has the following breaking changes which are all okay:

- automatically detect contentType if not provided (googleapis/nodejs-storage#1190)
- drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166)
- drop support for node.js 8.x
- allow leading slashes in file name (googleapis/nodejs-storage#820)
- upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)
BYK added a commit to getsentry/craft that referenced this pull request Jan 5, 2021
This is to upgrade the vulnerable `axios` dependency. The latest version has the following breaking changes which are all okay:

- automatically detect contentType if not provided (googleapis/nodejs-storage#1190)
- drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166)
- drop support for node.js 8.x
- allow leading slashes in file name (googleapis/nodejs-storage#820)
- upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)
BYK added a commit to getsentry/sentry-javascript that referenced this pull request Jan 11, 2021
This is to upgrade the vulnerable `date-and-time` dependency. The latest version has the following breaking changes which are all okay:

- automatically detect contentType if not provided (googleapis/nodejs-storage#1190)
- drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166)
- drop support for node.js 8.x
- allow leading slashes in file name (googleapis/nodejs-storage#820)
- upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants