docs(screenloads): Document span conditions for screen loads metrics #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cleptric
reviewed
May 21, 2024
Comment on lines
23
to
27
| ## Span Measurements | ||
| | Key | Unit | Description | | ||
| |:--|:--|:--| | ||
| | `time_to_initial_display` | milliseconds | The time it took to load the first frame | | ||
| | `time_to_full_display` | milliseconds | The time it took to fully load the screen | |
There was a problem hiding this comment.
Good question. I actually realized these are required on the transaction level at the moment (some of the widgets here still query transaction metrics) so I've split it out into a similar "Transaction Conventions" section.
time_to_initial_display is required for the module but time_to_full_display is optional and we prompt the user to manually instrument it.
cleptric
approved these changes
May 22, 2024
edwardgou-sentry
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the conditions for collecting span metrics to satisfy the screen loads module.
The screen loads module filters for specifically
ui.loadtransactions and will surface data from the following spans.