Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ui): Add examples of overriding default contexts #1288

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

scttcper
Copy link
Member

No description provided.

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 6:07pm

@scttcper scttcper changed the title test: add examples of overriding default contexts test: Add examples of overriding default contexts May 21, 2024
@scttcper scttcper changed the title test: Add examples of overriding default contexts test(ui): Add examples of overriding default contexts May 21, 2024
@scttcper scttcper requested a review from a team May 21, 2024 21:11
Copy link
Member

@ryan953 ryan953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put it higher in the file?

I would argue that the order goes:

  • render() first
  • query for stuff in the result

@scttcper scttcper enabled auto-merge (squash) May 22, 2024 18:06
@scttcper scttcper merged commit 5932b5a into master May 22, 2024
4 of 5 checks passed
@scttcper scttcper deleted the contexts branch May 22, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants