Lightly refactor main pubsub handler

[chadwhitacre]

Part of #482, after #512.

I'm pretty sure what I want to do is loop over multiple orgs in this handler (getsentry, codecov). This sets me up for that.

This also switches to requiring that repos be in payload. Can we do that? 🤔 Decided against this for now, too controversial.

[hubertdeng123]

This also switches to requiring that repos be in payload. Can we do that? 🤔 Decided against this for now, too controversial.

What do you mean here? Isn't repos already in the payload?

[hubertdeng123]

Do you mean hard requiring repos to be in the payload? And raising if it isn't? I guess we can do that but that's defined in the ops repo already so we have full control over that. https://github.com/getsentry/ops/blob/master/terraform/super-big-data/super-big-consumers/schedule.tf

[chadwhitacre]

What do you mean here? Isn't repos already in the payload?

It's optional, though ...

eng-pipes/src/webhooks/pubsub/index.ts

Line 17 in 78b7021

repos?: string[];

... and we fall back to a default.

eng-pipes/src/webhooks/pubsub/index.ts

Line 65 in 78b7021

repos = payload.repos || DEFAULT_REPOS;

Where is the payload defined? In GCP somewhere?

[chadwhitacre]

that's defined in the ops repo already so we have full control over that. https://github.com/getsentry/ops/blob/master/terraform/super-big-data/super-big-consumers/schedule.tf

The missing link! Thank you! 😁 🙏