Modules property is not serialized as well

[xpicio]

Hello, it's seems Modules property on JsonPacket is not serialized like sentry specification require. Instead of

{
    "modules": {
        "my.module.name": "1.0"
    }
}

Modules is serialized as

{
    "modules": [
        { "Name": "my.module.name", "Version": "1.0" }
    ]
}

Here xpicio@60dd480 can you find my fix. Is it my bad or a bug ?

Bye Bye

[asbjornu]

Hey. I've merged your changes into a new branch called modules-as-dictionary that you might want to take a look at. I had to build the dictionary manually, since it can't contain duplicates. Furthermore, the tests are failing because the server responding with (403) Forbidden. I guess that's related to the modules change, but I'm not sure.

[xpicio]

Hello. It's seems ok. I tested it on my sentry 6.4.4 server installation and the "Versions" section is rendered as well. Anyway i checked your code to build the dictionary and i was building it in the same way.

[asbjornu]

Yea, it was the serialization test that failed because the generated schema was based on the old (wrong) modules layout. I've regenerated the schema and the tests now pass.

[asbjornu]

This has been merged into the develop branch and will be merged to master as soon as possible.