Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XPATH to click breadcrumbs #783

Closed
takahashi64 opened this issue Nov 24, 2016 · 5 comments
Closed

Add XPATH to click breadcrumbs #783

takahashi64 opened this issue Nov 24, 2016 · 5 comments

Comments

@takahashi64
Copy link

For complex UI, the click breadcrumbs don't have enough detail - can you not include the XPATH of the element that is clicked? Otherwise its sometimes not possible to work out which element was clicked e.g. if there are multiple nested DIVs within a parent div, the breadcrumb could be rendered as DIV > DIV. This doesn't tell you which DIV was clicked.

@takahashi64
Copy link
Author

Originally brought up this issue in #576

@benvinegar
Copy link
Contributor

@takahashi64 – I'm not sure that we're going to do this or #576 for a few reasons:

  1. Breadcrumbs are intentionally supposed to be lightweight hints, they have character limits, and XPath statements can grow arbitrarily large. Also, the code for generating a full XPath string will likely bloat the library re: filesize.
  2. I've erred on not showing the exact click content for privacy reasons (e.g. in case the links clicked contains sensitive data).

@takahashi64
Copy link
Author

@benvinegar that makes a lot of sense yeah. Is there someway to make Raven extensible/pluggable so I could add custom logging to the sentry reports? For complex UI, it would really help if we knew what the user was doing. Thanks.

@benvinegar
Copy link
Contributor

We did add breadcrumbCallback, but it doesn't pass the original "object" that created the crumb, so you unfortunately can't construct your own XPATH string.

I think the only workaround presently is to basically instrument the DOM yourself and leave your own custom breadcrumbs.

@kamilogorek
Copy link
Contributor

kamilogorek commented Jan 19, 2018

I'll close this one for now, as we're aware of this missing piece and we'll be revisiting how this thing is working in the next major version.

Ref: #783
Ref: #576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants