New master version of Raven is kind of borked

[fredefl]

If I use the latest master version of raven-node, I get:

Blahblahdir\node_modules\raven\lib\utils.js:93
line.getTypeName() + '.' + (line.getMethodName() || '');
^
[object Arguments]

When running "client.captureError(new Error("Could not connect to server over Tor."));".

[fredefl]

The npm version I had before doesn't crash.

[mattrobenolt]

I'll take a look at it first thing in the morning. I have an idea of what
could be wrong. This is why I wasn't ready to tag it just yet. ;)

Sent from my iPhone

On Apr 7, 2013, at 4:09, Frederik Lassen notifications@github.com wrote:

The npm version I had before doesn't crash.

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/40#issuecomment-16013237
.

[fredefl]

Thank you! ;)

[mattrobenolt]

I can't seem to recreate this. Can you show me what you're doing? I lamely just tried:

var raven = require('../');
var client = new raven.Client('https://abc:xyz@app.getsentry.com/4291');

client.captureError(new Error("Could not connect to server over Tor."));

and it was fine, so I'm assuming there are other variables going into this.

[fredefl]

I might have found the problem. I'm using strict:
'use strict';

With it on it crashes, without it, it doesn't.

[mattrobenolt]

Well, that does it. Is that a thing that people use in Node? haha, I don't think I've ever seen it server side before.

[fredefl]

Haha, I don't really know.
I'm pretty new to Node, but I used it a lot in JavaScript, therefore I used it in Node as well.

I'll just leave it out. Everything works fine now!

I highly appreciate the time and effort you have put in this plugin, thanks a bunch!
Have a nice day!

[mattrobenolt]

@fredefl, I've tracked it specifically with #41. I'm going to see what's different and patch that up.

[fredefl]

Cool! All the other plugins I've used were compatible with strict, so yes, it might be necessary. 👍

[mattrobenolt]

Eh, fixed in master if you want to give it another shot for fun. :)

[fredefl]

Yes that fixes it, that was quick! :)
Just a quick heads up, this new version requires raw-stacktrace.

[mattrobenolt]

Yep. That was from another pull request I landed.

[fredefl]

Yeah I saw that. :)

[fredefl]

When will it land in the npm repos?

[mattrobenolt]

Today. I'm going to finish up the changelog and it should be good to go.

Matt Robenolt
@mattrobenolt

On Sunday, April 7, 2013 at 12:48 PM, Frederik Lassen wrote:

When will it land in the npm repos?

—
Reply to this email directly or view it on GitHub (#40 (comment)).

[fredefl]

Awesome, what will the version number be so I can verify?

[mattrobenolt]

I'm thinking a 0.5 since there is a decently large internal restructure. And I'm also going to yank out the NODE_ENV stuff. It's just becoming annoying to maintain with everyone's different opinions.

Matt Robenolt
@mattrobenolt

On Sunday, April 7, 2013 at 12:48 PM, Frederik Lassen wrote:

When will it land in the npm repos?

—
Reply to this email directly or view it on GitHub (#40 (comment)).

[fredefl]

Just a quick question.
I have this event that happens regularly - which is OK, but I still need to monitor it.
The event is regarding a single person, but happens to all persons in my database.

For example: "Error: Error while getting: mrFunkyFred".
However the message "Error: Error while getting: lePeteX" generates a different and completely seperate error message.

Is there any way I can include the persons name in the error report, without creating a seperate error type for each.
So the error should just be "Error: Error while getting person".

Thanks!

[mattrobenolt]

Wanna hop in IRC? #sentry on Freenode.